Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reapply DoltgresType changes with performance improvement #987

Merged
merged 28 commits into from
Dec 6, 2024
Merged

reapply DoltgresType changes with performance improvement #987

merged 28 commits into from
Dec 6, 2024

Conversation

jennifersp
Copy link
Contributor

@jennifersp jennifersp commented Nov 20, 2024 •
edited
Loading

Regressed CREATE VIEW test is tracked here.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 20, 2024 •
edited
Loading

Main PR
Total 42090 42090
Successful 14534 15127
Failures 27556 26963
Partial Successes1 4689 5221
Main PR
Successful 34.5308% 35.9397%
Failures 65.4692% 64.0603%

${\color{red}Regressions (2)}$

type_sanity

QUERY:          SELECT t1.oid, t1.typname, t1.typelem
FROM pg_type AS t1
WHERE t1.typelem != 0 AND t1.typsubscript = 0;
RECEIVED ERROR: function internal_binary_operator_func_=(text, integer) does not exist (errno 1105) (sqlstate HY000)

updatable_views

QUERY:          CREATE VIEW rw_view15 AS SELECT a, upper(b) FROM base_tbl;
RECEIVED ERROR: runtime error: invalid memory address or nil pointer dereference

${\color{lightgreen}Progressions (602)}$

alter_table

QUERY: SELECT c.oid::pg_catalog.regclass
FROM pg_catalog.pg_class c, pg_catalog.pg_inherits i
WHERE c.oid = i.inhparent AND i.inhrelid = '159776'
  AND c.relkind != 'p' AND c.relkind != 'I'
ORDER BY inhseqno;

QUERY: SELECT c.oid::pg_catalog.regclass, c.relkind, inhdetachpending, pg_catalog.pg_get_expr(c.relpartbound, c.oid)
FROM pg_catalog.pg_class c, pg_catalog.pg_inherits i
WHERE c.oid = i.inhrelid AND i.inhparent = '159776'
ORDER BY pg_catalog.pg_get_expr(c.relpartbound, c.oid) = 'DEFAULT', c.oid::pg_catalog.regclass::pg_catalog.text;

QUERY: SELECT c.oid::pg_catalog.regclass, c.relkind, inhdetachpending, pg_catalog.pg_get_expr(c.relpartbound, c.oid)
FROM pg_catalog.pg_class c, pg_catalog.pg_inherits i
WHERE c.oid = i.inhrelid AND i.inhparent = '159780'
ORDER BY pg_catalog.pg_get_expr(c.relpartbound, c.oid) = 'DEFAULT', c.oid::pg_catalog.regclass::pg_catalog.text;

QUERY: SELECT c.oid::pg_catalog.regclass
FROM pg_catalog.pg_class c, pg_catalog.pg_inherits i
WHERE c.oid = i.inhparent AND i.inhrelid = '159776'
  AND c.relkind != 'p' AND c.relkind != 'I'
ORDER BY inhseqno;

QUERY: SELECT c.oid::pg_catalog.regclass, c.relkind, inhdetachpending, pg_catalog.pg_get_expr(c.relpartbound, c.oid)
FROM pg_catalog.pg_class c, pg_catalog.pg_inherits i
WHERE c.oid = i.inhrelid AND i.inhparent = '159780'
ORDER BY pg_catalog.pg_get_expr(c.relpartbound, c.oid) = 'DEFAULT', c.oid::pg_catalog.regclass::pg_catalog.text;

QUERY: SELECT c.oid::pg_catalog.regclass
FROM pg_catalog.pg_class c, pg_catalog.pg_inherits i
WHERE c.oid = i.inhparent AND i.inhrelid = '159776'
  AND c.relkind != 'p' AND c.relkind != 'I'
ORDER BY inhseqno;

QUERY: SELECT c.oid::pg_catalog.regclass, c.relkind, inhdetachpending, pg_catalog.pg_get_expr(c.relpartbound, c.oid)
FROM pg_catalog.pg_class c, pg_catalog.pg_inherits i
WHERE c.oid = i.inhrelid AND i.inhparent = '159780'
ORDER BY pg_catalog.pg_get_expr(c.relpartbound, c.oid) = 'DEFAULT', c.oid::pg_catalog.regclass::pg_catalog.text;

QUERY: SELECT c.oid::pg_catalog.regclass
FROM pg_catalog.pg_class c, pg_catalog.pg_inherits i
WHERE c.oid = i.inhparent AND i.inhrelid = '159776'
  AND c.relkind != 'p' AND c.relkind != 'I'
ORDER BY inhseqno;

QUERY: SELECT c.oid::pg_catalog.regclass, c.relkind, inhdetachpending, pg_catalog.pg_get_expr(c.relpartbound, c.oid)
FROM pg_catalog.pg_class c, pg_catalog.pg_inherits i
WHERE c.oid = i.inhrelid AND i.inhparent = '159780'
ORDER BY pg_catalog.pg_get_expr(c.relpartbound, c.oid) = 'DEFAULT', c.oid::pg_catalog.regclass::pg_catalog.text;

QUERY: SELECT c.oid::pg_catalog.regclass
FROM pg_catalog.pg_class c, pg_catalog.pg_inherits i
WHERE c.oid = i.inhparent AND i.inhrelid = '159793'
  AND c.relkind != 'p' AND c.relkind != 'I'
ORDER BY inhseqno;

QUERY: SELECT c.oid::pg_catalog.regclass, c.relkind, inhdetachpending, pg_catalog.pg_get_expr(c.relpartbound, c.oid)
FROM pg_catalog.pg_class c, pg_catalog.pg_inherits i
WHERE c.oid = i.inhrelid AND i.inhparent = '159793'
ORDER BY pg_catalog.pg_get_expr(c.relpartbound, c.oid) = 'DEFAULT', c.oid::pg_catalog.regclass::pg_catalog.text;

QUERY: SELECT c.oid::pg_catalog.regclass
FROM pg_catalog.pg_class c, pg_catalog.pg_inherits i
WHERE c.oid = i.inhparent AND i.inhrelid = '159854'
  AND c.relkind != 'p' AND c.relkind != 'I'
ORDER BY inhseqno;

QUERY: SELECT c.oid::pg_catalog.regclass, c.relkind, inhdetachpending, pg_catalog.pg_get_expr(c.relpartbound, c.oid)
FROM pg_catalog.pg_class c, pg_catalog.pg_inherits i
WHERE c.oid = i.inhrelid AND i.inhparent = '159854'
ORDER BY pg_catalog.pg_get_expr(c.relpartbound, c.oid) = 'DEFAULT', c.oid::pg_catalog.regclass::pg_catalog.text;

QUERY: SELECT c.oid::pg_catalog.regclass, c.relkind, inhdetachpending, pg_catalog.pg_get_expr(c.relpartbound, c.oid)
FROM pg_catalog.pg_class c, pg_catalog.pg_inherits i
WHERE c.oid = i.inhrelid AND i.inhparent = '159866'
ORDER BY pg_catalog.pg_get_expr(c.relpartbound, c.oid) = 'DEFAULT', c.oid::pg_catalog.regclass::pg_catalog.text;

QUERY: SELECT c.oid::pg_catalog.regclass
FROM pg_catalog.pg_class c, pg_catalog.pg_inherits i
WHERE c.oid = i.inhparent AND i.inhrelid = '160350'
  AND c.relkind != 'p' AND c.relkind != 'I'
ORDER BY inhseqno;

QUERY: SELECT c.oid::pg_catalog.regclass, c.relkind, inhdetachpending, pg_catalog.pg_get_expr(c.relpartbound, c.oid)
FROM pg_catalog.pg_class c, pg_catalog.pg_inherits i
WHERE c.oid = i.inhrelid AND i.inhparent = '160350'
ORDER BY pg_catalog.pg_get_expr(c.relpartbound, c.oid) = 'DEFAULT', c.oid::pg_catalog.regclass::pg_catalog.text;

QUERY: SELECT c.oid::pg_catalog.regclass
FROM pg_catalog.pg_class c, pg_catalog.pg_inherits i
WHERE c.oid = i.inhparent AND i.inhrelid = '160350'
  AND c.relkind != 'p' AND c.relkind != 'I'
ORDER BY inhseqno;

QUERY: SELECT c.oid::pg_catalog.regclass, c.relkind, inhdetachpending, pg_catalog.pg_get_expr(c.relpartbound, c.oid)
FROM pg_catalog.pg_class c, pg_catalog.pg_inherits i
WHERE c.oid = i.inhrelid AND i.inhparent = '160350'
ORDER BY pg_catalog.pg_get_expr(c.relpartbound, c.oid) = 'DEFAULT', c.oid::pg_catalog.regclass::pg_catalog.text;

QUERY: create table at_tab2 (x int, y text, check((x,y)::at_tab1 = (1,'42')::at_tab1));

QUERY: drop table at_tab1, at_tab2;

QUERY: create table at_tab1 (a int, b text) partition by list(a);

QUERY: SELECT c.oid::pg_catalog.regclass
FROM pg_catalog.pg_class c, pg_catalog.pg_inherits i
WHERE c.oid = i.inhparent AND i.inhrelid = '160462'
  AND c.relkind != 'p' AND c.relkind != 'I'
ORDER BY inhseqno;

QUERY: SELECT c.oid::pg_catalog.regclass, c.relkind, inhdetachpending, pg_catalog.pg_get_expr(c.relpartbound, c.oid)
FROM pg_catalog.pg_class c, pg_catalog.pg_inherits i
WHERE c.oid = i.inhrelid AND i.inhparent = '160462'
ORDER BY pg_catalog.pg_get_expr(c.relpartbound, c.oid) = 'DEFAULT', c.oid::pg_catalog.regclass::pg_catalog.text;

QUERY: SELECT c.oid::pg_catalog.regclass
FROM pg_catalog.pg_class c, pg_catalog.pg_inherits i
WHERE c.oid = i.inhparent AND i.inhrelid = '160467'
  AND c.relkind != 'p' AND c.relkind != 'I'
ORDER BY inhseqno;

QUERY: SELECT c.oid::pg_catalog.regclass, c.relkind, inhdetachpending, pg_catalog.pg_get_expr(c.relpartbound, c.oid)
FROM pg_catalog.pg_class c, pg_catalog.pg_inherits i
WHERE c.oid = i.inhrelid AND i.inhparent = '160467'
ORDER BY pg_catalog.pg_get_expr(c.relpartbound, c.oid) = 'DEFAULT', c.oid::pg_catalog.regclass::pg_catalog.text;

QUERY: SELECT c.oid::pg_catalog.regclass
FROM pg_catalog.pg_class c, pg_catalog.pg_inherits i
WHERE c.oid = i.inhparent AND i.inhrelid = '160467'
  AND c.relkind != 'p' AND c.relkind != 'I'
ORDER BY inhseqno;

QUERY: SELECT c.oid::pg_catalog.regclass, c.relkind, inhdetachpending, pg_catalog.pg_get_expr(c.relpartbound, c.oid)
FROM pg_catalog.pg_class c, pg_catalog.pg_inherits i
WHERE c.oid = i.inhrelid AND i.inhparent = '160467'
ORDER BY pg_catalog.pg_get_expr(c.relpartbound, c.oid) = 'DEFAULT', c.oid::pg_catalog.regclass::pg_catalog.text;

QUERY: SELECT c.oid::pg_catalog.regclass
FROM pg_catalog.pg_class c, pg_catalog.pg_inherits i
WHERE c.oid = i.inhparent AND i.inhrelid = '160462'
  AND c.relkind != 'p' AND c.relkind != 'I'
ORDER BY inhseqno;

QUERY: SELECT c.oid::pg_catalog.regclass, c.relkind, inhdetachpending, pg_catalog.pg_get_expr(c.relpartbound, c.oid)
FROM pg_catalog.pg_class c, pg_catalog.pg_inherits i
WHERE c.oid = i.inhrelid AND i.inhparent = '160462'
ORDER BY pg_catalog.pg_get_expr(c.relpartbound, c.oid) = 'DEFAULT', c.oid::pg_catalog.regclass::pg_catalog.text;

QUERY: SELECT c.oid::pg_catalog.regclass
FROM pg_catalog.pg_class c, pg_catalog.pg_inherits i
WHERE c.oid = i.inhparent AND i.inhrelid = '160467'
  AND c.relkind != 'p' AND c.relkind != 'I'
ORDER BY inhseqno;

QUERY: SELECT c.oid::pg_catalog.regclass, c.relkind, inhdetachpending, pg_catalog.pg_get_expr(c.relpartbound, c.oid)
FROM pg_catalog.pg_class c, pg_catalog.pg_inherits i
WHERE c.oid = i.inhrelid AND i.inhparent = '160467'
ORDER BY pg_catalog.pg_get_expr(c.relpartbound, c.oid) = 'DEFAULT', c.oid::pg_catalog.regclass::pg_catalog.text;

QUERY: SELECT c.oid::pg_catalog.regclass
FROM pg_catalog.pg_class c, pg_catalog.pg_inherits i
WHERE c.oid = i.inhparent AND i.inhrelid = '160529'
  AND c.relkind != 'p' AND c.relkind != 'I'
ORDER BY inhseqno;

QUERY: SELECT c.oid::pg_catalog.regclass, c.relkind, inhdetachpending, pg_catalog.pg_get_expr(c.relpartbound, c.oid)
FROM pg_catalog.pg_class c, pg_catalog.pg_inherits i
WHERE c.oid = i.inhrelid AND i.inhparent = '160529'
ORDER BY pg_catalog.pg_get_expr(c.relpartbound, c.oid) = 'DEFAULT', c.oid::pg_catalog.regclass::pg_catalog.text;

QUERY: SELECT c.oid::pg_catalog.regclass
FROM pg_catalog.pg_class c, pg_catalog.pg_inherits i
WHERE c.oid = i.inhparent AND i.inhrelid = '160541'
  AND c.relkind != 'p' AND c.relkind != 'I'
ORDER BY inhseqno;

QUERY: SELECT c.oid::pg_catalog.regclass, c.relkind, inhdetachpending, pg_catalog.pg_get_expr(c.relpartbound, c.oid)
FROM pg_catalog.pg_class c, pg_catalog.pg_inherits i
WHERE c.oid = i.inhrelid AND i.inhparent = '160545'
ORDER BY pg_catalog.pg_get_expr(c.relpartbound, c.oid) = 'DEFAULT', c.oid::pg_catalog.regclass::pg_catalog.text;

QUERY: SELECT c.oid::pg_catalog.regclass
FROM pg_catalog.pg_class c, pg_catalog.pg_inherits i
WHERE c.oid = i.inhparent AND i.inhrelid = '160541'
  AND c.relkind != 'p' AND c.relkind != 'I'
ORDER BY inhseqno;

QUERY: SELECT c.oid::pg_catalog.regclass, c.relkind, inhdetachpending, pg_catalog.pg_get_expr(c.relpartbound, c.oid)
FROM pg_catalog.pg_class c, pg_catalog.pg_inherits i
WHERE c.oid = i.inhrelid AND i.inhparent = '160545'
ORDER BY pg_catalog.pg_get_expr(c.relpartbound, c.oid) = 'DEFAULT', c.oid::pg_catalog.regclass::pg_catalog.text;

QUERY: SELECT c.oid::pg_catalog.regclass
FROM pg_catalog.pg_class c, pg_catalog.pg_inherits i
WHERE c.oid = i.inhparent AND i.inhrelid = '160541'
  AND c.relkind != 'p' AND c.relkind != 'I'
ORDER BY inhseqno;

QUERY: SELECT c.oid::pg_catalog.regclass, c.relkind, inhdetachpending, pg_catalog.pg_get_expr(c.relpartbound, c.oid)
FROM pg_catalog.pg_class c, pg_catalog.pg_inherits i
WHERE c.oid = i.inhrelid AND i.inhparent = '160545'
ORDER BY pg_catalog.pg_get_expr(c.relpartbound, c.oid) = 'DEFAULT', c.oid::pg_catalog.regclass::pg_catalog.text;

QUERY: SELECT c.oid::pg_catalog.regclass
FROM pg_catalog.pg_class c, pg_catalog.pg_inherits i
WHERE c.oid = i.inhparent AND i.inhrelid = '160541'
  AND c.relkind != 'p' AND c.relkind != 'I'
ORDER BY inhseqno;

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct. ↩

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 20, 2024 •
edited
Loading

Main PR
covering_index_scan_postgres 450.84/s ${\color{red}387.70/s}$ ${\color{red}-14.1\%}$
index_join_postgres 163.06/s 155.85/s -4.5%
index_join_scan_postgres 188.25/s 189.39/s +0.6%
index_scan_postgres 15.13/s ${\color{red}12.69/s}$ ${\color{red}-16.2\%}$
oltp_point_select 2808.19/s 2830.04/s +0.7%
oltp_read_only 1913.11/s 1891.84/s -1.2%
select_random_points 120.60/s 113.68/s -5.8%
select_random_ranges 91.99/s ${\color{lightgreen}143.88/s}$ ${\color{lightgreen}+56.4\%}$
table_scan_postgres 14.78/s ${\color{red}12.25/s}$ ${\color{red}-17.2\%}$
types_table_scan_postgres 6.83/s ${\color{red}5.62/s}$ ${\color{red}-17.8\%}$

jennifersp and others added 23 commits November 20, 2024 14:55
@jennifersp
t
3f50d46
@jennifersp
fix linter
222fbd7
@jennifersp
update
b2d7657
@jennifersp
add TODOs for nil context resolution
2028179
@jennifersp
Merge branch 'main' into jennifer/type-changes
f8d78fd
@jennifersp
update
905790c
@jennifersp
update typmod
60a2d05
@Hydrocharged
Reworked DoltgresType function access
198a3c9
@jennifersp
Merge pull request #1014 from dolthub/daylon/function-speedup
bb12fad 
Reworked DoltgresType function access
@jennifersp
update postgres client test
c717c81
@jennifersp
use OID instead of DoltgresType struct for functions and casts
a73cde9
@jennifersp
switch DoltgresType to be used as pointer
99c9d90
@jennifersp
uncomment
061b3a3
@jennifersp
format and fix
ea752a7
@jennifersp
make attTypMod not export to avoid getting built in types get updated
cb18c77
@jennifersp
not use DoltgresType.String() method before all the functions are ini…
4ebafac 
…tialized
@jennifersp
revert a73cde9
356e822
@jennifersp
Merge branch 'main' into jennifer/type-pointer
ee6b30d
@jennifersp
allow 'QuickFunctionN.WithChildren()'
c4747cd
@jennifersp
Merge pull request #1033 from dolthub/jennifer/type-pointer
3ac214d 
switch DoltgresType to be used as pointer
@jennifersp
Merge branch 'main' into jennifer/type-changes
99eedd0
@jennifersp
Revert "allow 'QuickFunctionN.WithChildren()'"
8caee28 
This reverts commit c4747cd.
@jennifersp
fix
e271d59
@jennifersp jennifersp marked this pull request as ready for review December 5, 2024 23:30
@jennifersp jennifersp requested a review from tbantle22 as a code owner December 5, 2024 23:30
Hydrocharged
Hydrocharged approved these changes Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jennifersp jennifersp merged commit 064a3d0 into main Dec 6, 2024
14 checks passed
@jennifersp jennifersp deleted the jennifer/type-changes branch December 6, 2024 19:23
@BrewTestBot BrewTestBot mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hydrocharged Hydrocharged Hydrocharged approved these changes

@tbantle22 tbantle22 Awaiting requested review from tbantle22 tbantle22 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jennifersp @Hydrocharged